Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new functions to CIMC modules #46222

Merged
merged 4 commits into from Mar 5, 2018
Merged

Added new functions to CIMC modules #46222

merged 4 commits into from Mar 5, 2018

Conversation

@spenceation
Copy link
Contributor

@spenceation spenceation commented Feb 27, 2018

What does this PR do?

Add new CIMC Execution modules:

  • get_hostname
  • get_power_configuration
  • get_syslog_settings
  • set_hostname
  • set_logging_levels
  • set_power_configuration
  • set_user

Add new CIMC State Modules:

  • hostname
  • logging_levels
  • power_configuration
  • user

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

spenceation added 2 commits Feb 27, 2018
  - get_hostname
  - get_power_configuration
  - get_syslog_settings
  - set_hostname
  - set_logging_levels
  - set_power_configuration
  - set_user

Add new CIMC State Modules:
  - hostname
  - logging_levels
  - power_configuration
  - user
Copy link
Contributor

@rallytime rallytime left a comment

This looks good to me. Very nice. The only thing I would say is that these new functions should have .. versionadded:: Fluorine tags.

@spenceation
Copy link
Contributor Author

@spenceation spenceation commented Mar 1, 2018

@rallytime I've added the requested version tags. Please let me know if there are any issues with them.

@rallytime
Copy link
Contributor

@rallytime rallytime commented Mar 1, 2018

@rallytime rallytime merged commit ed1108a into saltstack:develop Mar 5, 2018
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants