Added new functions to CIMC modules#46222
Merged
rallytime merged 4 commits intosaltstack:developfrom Mar 5, 2018
spenceation:cimc-update
Merged
Added new functions to CIMC modules#46222rallytime merged 4 commits intosaltstack:developfrom spenceation:cimc-update
rallytime merged 4 commits intosaltstack:developfrom
spenceation:cimc-update
Conversation
- get_hostname - get_power_configuration - get_syslog_settings - set_hostname - set_logging_levels - set_power_configuration - set_user Add new CIMC State Modules: - hostname - logging_levels - power_configuration - user
rallytime
suggested changes
Feb 28, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
This looks good to me. Very nice. The only thing I would say is that these new functions should have .. versionadded:: Fluorine tags.
Contributor
Author
|
@rallytime I've added the requested version tags. Please let me know if there are any issues with them. |
rallytime
approved these changes
Mar 1, 2018
Contributor
|
@spenceation Thanks! There's a tiny lint error here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/19716/violations/file/salt/modules/cimc.py/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new CIMC Execution modules:
Add new CIMC State Modules:
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.