Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new functions to CIMC modules #46222

Merged
merged 4 commits into from Mar 5, 2018

Conversation

Projects
None yet
2 participants
@spenceation
Copy link
Contributor

commented Feb 27, 2018

What does this PR do?

Add new CIMC Execution modules:

  • get_hostname
  • get_power_configuration
  • get_syslog_settings
  • set_hostname
  • set_logging_levels
  • set_power_configuration
  • set_user

Add new CIMC State Modules:

  • hostname
  • logging_levels
  • power_configuration
  • user

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

spenceation added some commits Feb 27, 2018

Add new CIMC Execution modules:
  - get_hostname
  - get_power_configuration
  - get_syslog_settings
  - set_hostname
  - set_logging_levels
  - set_power_configuration
  - set_user

Add new CIMC State Modules:
  - hostname
  - logging_levels
  - power_configuration
  - user
@rallytime
Copy link
Contributor

left a comment

This looks good to me. Very nice. The only thing I would say is that these new functions should have .. versionadded:: Fluorine tags.

@spenceation

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2018

@rallytime I've added the requested version tags. Please let me know if there are any issues with them.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2018

@rallytime rallytime merged commit ed1108a into saltstack:develop Mar 5, 2018

3 of 10 checks passed

codeclimate 17 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15177 — FAILURE
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #2791 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20440 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #7355 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #16842 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #22845 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #19790 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.