Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
salt/states/lxd.py
Outdated
| ''' | ||
| Manage LXD profiles. | ||
| .. versionadded:: unknown |
This comment has been minimized.
This comment has been minimized.
pcdummy
force-pushed the
pcdummy:add_lxd_support
branch
from
6ece187
to
9e5850f
Feb 27, 2018
This comment has been minimized.
This comment has been minimized.
|
This looks great! Thanks for submitting these! |
pcdummy
force-pushed the
pcdummy:add_lxd_support
branch
4 times, most recently
from
b0a5c26
to
c72f5c0
Feb 27, 2018
This comment has been minimized.
This comment has been minimized.
|
@pcdummy Can you write some tests for these new modules/states? |
rallytime
added
the
Needs Testcase
label
Feb 28, 2018
This comment has been minimized.
This comment has been minimized.
|
@rallytime Don't think i get the time for doing so and i even wouldn't know where to start with tests. |
pcdummy
force-pushed the
pcdummy:add_lxd_support
branch
from
c72f5c0
to
7a52de6
Mar 4, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rallytime I have added an issue for adding tests for this before the fluorine release. |
This comment has been minimized.
This comment has been minimized.
|
re-run all |
pcdummy
force-pushed the
pcdummy:add_lxd_support
branch
from
7a52de6
to
d70d8fc
Apr 3, 2018
rallytime
removed
the
Needs Testcase
label
Apr 3, 2018
cachedout
merged commit be7c756
into
saltstack:develop
Apr 4, 2018
4 of 10 checks passed
jenkins/PR/salt-pr-rs-cent7-n
Pull Requests » Salt PR - RS CentOS 7 #17753 — ABORTED
Details
codeclimate
222 issues to fix
Details
default
Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3
Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3710 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n
Pull Requests » Salt PR - Linode Ubuntu14.04 #21438 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3
Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8507 — FAILURE
Details
WIP
ready for review
Details
jenkins/PR/salt-pr-clone
Pull Requests » Salt PR - Clone #23867 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n
Pull Requests » Salt PR - Docs #16041 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n
Pull Requests » Salt PR - Code Lint #20660 — SUCCESS
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pcdummy commentedFeb 27, 2018
What does this PR do?
Adds support for LXD (Containers, Images and Profiles).
It lived for a long time in LXD Formula.
Authors:
Me
keesbos
sferket
Tests written?
No
Commits signed with GPG?
Yes