Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxd module and states #46231

Merged
merged 1 commit into from Apr 4, 2018
Merged

Add lxd module and states #46231

merged 1 commit into from Apr 4, 2018

Conversation

@pcdummy
Copy link
Contributor

@pcdummy pcdummy commented Feb 27, 2018

What does this PR do?

Adds support for LXD (Containers, Images and Profiles).

It lived for a long time in LXD Formula.

Authors:
Me
keesbos
sferket

Tests written?

No

Commits signed with GPG?

Yes

'''
Manage LXD profiles.
.. versionadded:: unknown

This comment has been minimized.

@gtmanfred

gtmanfred Feb 27, 2018
Contributor

This will be Fluorine


# PEP8
__opts__ = {}
__salt__ = {}

This comment has been minimized.

@gtmanfred

gtmanfred Feb 27, 2018
Contributor

These are not needed, we excempt salt and opts in our pylint.

@pcdummy pcdummy force-pushed the pcdummy:add_lxd_support branch from 6ece187 to 9e5850f Feb 27, 2018
@gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Feb 27, 2018

This looks great! Thanks for submitting these!

@pcdummy pcdummy force-pushed the pcdummy:add_lxd_support branch 4 times, most recently from b0a5c26 to c72f5c0 Feb 27, 2018
@rallytime
Copy link
Contributor

@rallytime rallytime commented Feb 28, 2018

@pcdummy Can you write some tests for these new modules/states?

@pcdummy
Copy link
Contributor Author

@pcdummy pcdummy commented Mar 1, 2018

@rallytime Don't think i get the time for doing so and i even wouldn't know where to start with tests.

@pcdummy pcdummy force-pushed the pcdummy:add_lxd_support branch from c72f5c0 to 7a52de6 Mar 4, 2018
@rallytime
Copy link
Contributor

@rallytime rallytime commented Mar 13, 2018

@pcdummy There's some documentation here and we are happy to answer any questions. We won't be able to add new modules and states without some test coverage.

@gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Apr 3, 2018

@rallytime I have added an issue for adding tests for this before the fluorine release.

@gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Apr 3, 2018

re-run all

@pcdummy pcdummy force-pushed the pcdummy:add_lxd_support branch from 7a52de6 to d70d8fc Apr 3, 2018
@cachedout cachedout merged commit be7c756 into saltstack:develop Apr 4, 2018
4 of 10 checks passed
4 of 10 checks passed
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17753 — ABORTED
Details
codeclimate 222 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3710 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21438 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8507 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23867 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16041 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20660 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants