Add lxd module and states#46231
Merged
Merged
Conversation
gtmanfred
suggested changes
Feb 27, 2018
Contributor
There was a problem hiding this comment.
These are not needed, we excempt salt and opts in our pylint.
gtmanfred
approved these changes
Feb 27, 2018
Contributor
|
This looks great! Thanks for submitting these! |
Contributor
|
@pcdummy Can you write some tests for these new modules/states? |
rallytime
added
the
needs-testcase
Author
|
@rallytime Don't think i get the time for doing so and i even wouldn't know where to start with tests. |
Contributor
|
@pcdummy There's some documentation here and we are happy to answer any questions. We won't be able to add new modules and states without some test coverage. |
Contributor
|
@rallytime I have added an issue for adding tests for this before the fluorine release. |
Contributor
|
re-run all |
rallytime
removed
the
needs-testcase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for LXD (Containers, Images and Profiles).
It lived for a long time in LXD Formula.
Authors:
Me
keesbos
sferket
Tests written?
No
Commits signed with GPG?
Yes