Add lxd module and states #46231
Merged
Add lxd module and states #46231
Conversation
salt/states/lxd.py
Outdated
''' | ||
Manage LXD profiles. | ||
.. versionadded:: unknown |
gtmanfred
Feb 27, 2018
Contributor
This will be Fluorine
This will be Fluorine
salt/states/lxd.py
Outdated
|
||
# PEP8 | ||
__opts__ = {} | ||
__salt__ = {} |
gtmanfred
Feb 27, 2018
Contributor
These are not needed, we excempt salt and opts in our pylint.
These are not needed, we excempt salt and opts in our pylint.
This looks great! Thanks for submitting these! |
b0a5c26
to
c72f5c0
@pcdummy Can you write some tests for these new modules/states? |
@rallytime Don't think i get the time for doing so and i even wouldn't know where to start with tests. |
@rallytime I have added an issue for adding tests for this before the fluorine release. |
re-run all |
be7c756
into
saltstack:develop
4 of 10 checks passed
4 of 10 checks passed
jenkins/PR/salt-pr-linode-cent7-py3
Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3710 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n
Pull Requests » Salt PR - Linode Ubuntu14.04 #21438 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3
Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8507 — FAILURE
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What does this PR do?
Adds support for LXD (Containers, Images and Profiles).
It lived for a long time in LXD Formula.
Authors:
Me
keesbos
sferket
Tests written?
No
Commits signed with GPG?
Yes