Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setopt support to yumpkg (and pkg.installed state) #46263

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
4 participants
@terminalmage
Copy link
Contributor

commented Feb 28, 2018

Resolves #46212.

@@ -258,6 +263,9 @@ def _get_options(**kwargs):
log.info('Adding branch \'%s\'', branch)
ret.append('--branch={0}'.format(branch))

for item in setopt:
ret.extend(['--setopt', six.text_type(item)])

This comment has been minimized.

Copy link
@djsly

djsly Feb 28, 2018

I'm assuming that the yum argument supports --setopt=obsoletes=0 as well as --setopt obsoletes=0 and that the later case will be used

This comment has been minimized.

Copy link
@terminalmage

terminalmage Feb 28, 2018

Author Contributor

Yes, I tested using multiple --setopt on the CLI and it worked like that. I just preferred to do it that way to avoid any confusion with more than one = sign, though it does work both ways. Really just a preference thing, it would have worked the other way too.

This comment has been minimized.

Copy link
@djsly

djsly Feb 28, 2018

thanks for confirming :)

@djsly

djsly approved these changes Feb 28, 2018

Copy link

left a comment

LGTM

@terminalmage terminalmage changed the title Add setopt support to yumpkg (and pkg.insalled state) Add setopt support to yumpkg (and pkg.installed state) Feb 28, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2018

re-run py

@rallytime rallytime merged commit a3ad308 into saltstack:develop Mar 5, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #2800 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20449 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #7364 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #16851 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #22854 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15074 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #19686 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:issue46212 branch Mar 8, 2018

@mruepp

This comment has been minimized.

Copy link

commented Aug 13, 2018

Will this be in 2018.3? This feature is really urgent, K8s 1.11 will only support 17.03.X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.