Add setopt support to yumpkg (and pkg.installed state)#46263
Merged
rallytime merged 1 commit intosaltstack:developfrom Mar 5, 2018
Merged
Add setopt support to yumpkg (and pkg.installed state)#46263rallytime merged 1 commit intosaltstack:developfrom
rallytime merged 1 commit intosaltstack:developfrom
Conversation
djsly
reviewed
Feb 28, 2018
| ret.append('--branch={0}'.format(branch)) | ||
|
|
||
| for item in setopt: | ||
| ret.extend(['--setopt', six.text_type(item)]) |
There was a problem hiding this comment.
I'm assuming that the yum argument supports --setopt=obsoletes=0 as well as --setopt obsoletes=0 and that the later case will be used
Contributor
Author
There was a problem hiding this comment.
Yes, I tested using multiple --setopt on the CLI and it worked like that. I just preferred to do it that way to avoid any confusion with more than one = sign, though it does work both ways. Really just a preference thing, it would have worked the other way too.
terminalmage
changed the title
rallytime
approved these changes
Mar 1, 2018
Contributor
|
re-run py |
|
Will this be in 2018.3? This feature is really urgent, K8s 1.11 will only support 17.03.X |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #46212.