Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setopt support to yumpkg (and pkg.installed state) #46263

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

terminalmage
Copy link
Contributor

Resolves #46212.

@@ -258,6 +263,9 @@ def _get_options(**kwargs):
log.info('Adding branch \'%s\'', branch)
ret.append('--branch={0}'.format(branch))

for item in setopt:
ret.extend(['--setopt', six.text_type(item)])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the yum argument supports --setopt=obsoletes=0 as well as --setopt obsoletes=0 and that the later case will be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tested using multiple --setopt on the CLI and it worked like that. I just preferred to do it that way to avoid any confusion with more than one = sign, though it does work both ways. Really just a preference thing, it would have worked the other way too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for confirming :)

Copy link

@djsly djsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terminalmage terminalmage changed the title Add setopt support to yumpkg (and pkg.insalled state) Add setopt support to yumpkg (and pkg.installed state) Feb 28, 2018
@rallytime
Copy link
Contributor

re-run py

@rallytime rallytime merged commit a3ad308 into saltstack:develop Mar 5, 2018
@terminalmage terminalmage deleted the issue46212 branch March 8, 2018 01:14
@mruepp
Copy link

mruepp commented Aug 13, 2018

Will this be in 2018.3? This feature is really urgent, K8s 1.11 will only support 17.03.X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants