Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow excluding multiple directories in rsync #46515

Merged
merged 1 commit into from Apr 10, 2018

Conversation

@gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Mar 13, 2018

What does this PR do?

Allow passing multiple paths to excludes in the rsync.rsync module

What issues does this PR fix or reference?

Closes #46505

Commits signed with GPG?

Yes

@rallytime
Copy link
Contributor

@rallytime rallytime commented Mar 20, 2018

re-run py

@rallytime
Copy link
Contributor

@rallytime rallytime commented Mar 20, 2018

@gtmanfred Can you write a test for this?

@rallytime
Copy link
Contributor

@rallytime rallytime commented Apr 3, 2018

@gtmanfred Just checking in here again - did you get a chance to write a test for this?

@gtmanfred
Copy link
Contributor Author

@gtmanfred gtmanfred commented Apr 3, 2018

Whoops, yes I can write a test for it.

@gtmanfred
Copy link
Contributor Author

@gtmanfred gtmanfred commented Apr 10, 2018

test added

@gtmanfred gtmanfred removed their assignment Apr 10, 2018
@rallytime rallytime merged commit fa9c3c0 into saltstack:develop Apr 10, 2018
5 of 10 checks passed
5 of 10 checks passed
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3941 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21705 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8770 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17987 — RUNNING
Details
@wip[bot]
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24105 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16259 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20878 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants