Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] global splay for scheduler #46525

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Adding the ability to set a global splay for all jobs in the scheduler. Useful for setting splay to internal jobs. Also adding additional integration tests to test global splay as well as per job splay options.

What issues does this PR fix or reference?

#46462

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@rallytime
Copy link
Contributor

@garethgreenaway There's a conflicting file on this one now. Can you fix that up?

…r. Useful for setting splay to internal jobs. Also adding additional integration tests to test global splay as well as per job splay options.
@@ -1314,10 +1316,13 @@ def _handle_until(job, data):
self.skip_during_range = schedule['skip_during_range']
if 'enabled' in schedule:
self.enabled = schedule['enabled']
if 'splay' in schedule:
self.splay = schedule['splay']

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this override your global set value at init time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. You're not passing it as a class init argument.

@cachedout
Copy link
Contributor

re-run all

@rallytime
Copy link
Contributor

re-run py

@cachedout
Copy link
Contributor

@rallytime This should be ready once tests run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants