Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running the schedule jobs to run in the foreground. #46544

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@s0undt3ch
Copy link
Member

commented Mar 14, 2018

What does this PR do?

Allows the scheduler to run jobs in the foreground.

Previous Behavior

Schedule jobs always ran in the background either on a new process or a thread.

Tests written?

No

Commits signed with GPG?

Yes

@s0undt3ch s0undt3ch requested a review from garethgreenaway Mar 14, 2018

@@ -408,23 +408,27 @@ def run_job(self, name):

# Grab run, assume True
run = data.get('run', True)
run_jobs_in_background = self.opts.get('run_jobs_in_background', True)

This comment has been minimized.

Copy link
@s0undt3ch

s0undt3ch Mar 14, 2018

Author Member

should it be run_schedule_jobs_in_background? On the salt side, opts is the whole set of options....

This comment has been minimized.

Copy link
@garethgreenaway

garethgreenaway Mar 14, 2018

Member

Should probably be run_schedule_jobs_in_background.

This comment has been minimized.

Copy link
@s0undt3ch

s0undt3ch Mar 16, 2018

Author Member

Updated

@s0undt3ch s0undt3ch force-pushed the s0undt3ch:features/schedule-job-func branch from 0cf0fdc to fd7c14d Mar 16, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2018

re-run py3

@rallytime rallytime merged commit 12fd498 into saltstack:develop Mar 20, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17276 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20892 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8035 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3309 — RUNNING
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23430 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15592 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20204 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.