Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running the schedule jobs to run in the foreground. #46544

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

Allows the scheduler to run jobs in the foreground.

Previous Behavior

Schedule jobs always ran in the background either on a new process or a thread.

Tests written?

No

Commits signed with GPG?

Yes

@@ -408,23 +408,27 @@ def run_job(self, name):

# Grab run, assume True
run = data.get('run', True)
run_jobs_in_background = self.opts.get('run_jobs_in_background', True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be run_schedule_jobs_in_background? On the salt side, opts is the whole set of options....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be run_schedule_jobs_in_background.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@rallytime
Copy link
Contributor

re-run py3

@rallytime rallytime merged commit 12fd498 into saltstack:develop Mar 20, 2018
@s0undt3ch s0undt3ch deleted the features/schedule-job-func branch April 24, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants