Allow running the schedule jobs to run in the foreground. #46544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
commented
Mar 14, 2018
salt/utils/schedule.py
Outdated
Collaborator
Author
There was a problem hiding this comment.
should it be run_schedule_jobs_in_background? On the salt side, opts is the whole set of options....
Contributor
There was a problem hiding this comment.
Should probably be run_schedule_jobs_in_background.
s0undt3ch
force-pushed
the
features/schedule-job-func
branch
from
0cf0fdc to
fd7c14d
Compare
garethgreenaway
approved these changes
Mar 16, 2018
Contributor
|
re-run py3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows the scheduler to run jobs in the foreground.
Previous Behavior
Schedule jobs always ran in the background either on a new process or a thread.
Tests written?
No
Commits signed with GPG?
Yes