Volume password #46694
Merged
Volume password #46694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
rallytime
suggested changes
Mar 26, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
I have one small request, otherwise LGTM.
| ProfitBricks supplied HDD (not ISO) images. The password must contain at | ||
| least 8 and no more than 50 characters. Only these characters are | ||
| allowed: [a-z][A-Z][0-9] | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add a .. versionadded:: Fluorine tag to this new option?
Contributor
There was a problem hiding this comment.
@rallytime I added the tag. Could you please review,
rallytime
approved these changes
Mar 27, 2018
Contributor
|
@edevenport Ah, there's a small lint error: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/20450/violations/file/salt/cloud/clouds/profitbricks.py/ |
Contributor
|
@rallytime Thanks for heads up. Fixed |
Contributor
|
re-run py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows a image root password to be set for server console access. SSH keys are required and now an password is optional.
Tests written?
No
Commits signed with GPG?
No