Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume password #46694

Merged
merged 6 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@edevenport
Copy link
Contributor

commented Mar 23, 2018

What does this PR do?

Allows a image root password to be set for server console access. SSH keys are required and now an password is optional.

Tests written?

No

Commits signed with GPG?

No

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Mar 23, 2018

@rallytime
Copy link
Contributor

left a comment

I have one small request, otherwise LGTM.

ProfitBricks supplied HDD (not ISO) images. The password must contain at
least 8 and no more than 50 characters. Only these characters are
allowed: [a-z][A-Z][0-9]

This comment has been minimized.

Copy link
@rallytime

rallytime Mar 26, 2018

Contributor

Can you add a .. versionadded:: Fluorine tag to this new option?

This comment has been minimized.

Copy link
@denza

denza Mar 26, 2018

Contributor

@rallytime I added the tag. Could you please review,

@denza denza force-pushed the StackPointCloud:volume_password branch from 8b9587e to 9e582c2 Mar 26, 2018

@rallytime

This comment has been minimized.

@denza

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

@rallytime Thanks for heads up. Fixed

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

re-run py

@rallytime rallytime merged commit 6fb83b7 into saltstack:develop Mar 29, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3565 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17604 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21279 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8345 — FAILURE
Details
WIP ready for review
Details
codeclimate 1 fixed issue
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23716 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15879 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20497 — SUCCESS
Details

@edevenport edevenport deleted the StackPointCloud:volume_password branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.