Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume password #46694

Merged
merged 6 commits into from Mar 29, 2018
Merged

Volume password #46694

merged 6 commits into from Mar 29, 2018

Conversation

edevenport
Copy link
Contributor

What does this PR do?

Allows a image root password to be set for server console access. SSH keys are required and now an password is optional.

Tests written?

No

Commits signed with GPG?

No

@ghost ghost self-requested a review March 23, 2018 21:16
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small request, otherwise LGTM.

ProfitBricks supplied HDD (not ISO) images. The password must contain at
least 8 and no more than 50 characters. Only these characters are
allowed: [a-z][A-Z][0-9]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .. versionadded:: Fluorine tag to this new option?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rallytime I added the tag. Could you please review,

@rallytime
Copy link
Contributor

@denza
Copy link
Contributor

denza commented Mar 28, 2018

@rallytime Thanks for heads up. Fixed

@rallytime
Copy link
Contributor

re-run py

@rallytime rallytime merged commit 6fb83b7 into saltstack:develop Mar 29, 2018
@edevenport edevenport deleted the volume_password branch March 29, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants