New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shrinking list in for loop bug #46776

merged 1 commit into from Apr 3, 2018


None yet
3 participants

gtmanfred commented Mar 29, 2018

What issues does this PR fix or reference?

Fixes #46765

Tests written?


Commits signed with GPG?


@@ -2582,7 +2582,7 @@ def mod_repo(repo, basedir=None, **kwargs):
# Build a list of keys to be deleted
todelete = []
for key in repo_opts:
for key in list(repo_opts):

This comment has been minimized.


cachedout Mar 30, 2018


I think some inline documentation here about why this is required would help us avoid confusion in the future.

@gtmanfred gtmanfred force-pushed the gtmanfred:2017.7 branch from 506db7d to edc1059 Mar 30, 2018

@rallytime rallytime merged commit f2dd79f into saltstack:2017.7 Apr 3, 2018

5 of 9 checks passed

default Build finished.
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3630 — FAILURE
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21348 — FAILURE
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17673 — FAILURE
WIP ready for review
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23785 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15966 — SUCCESS
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8411 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20584 — SUCCESS

gtmanfred added a commit that referenced this pull request Jun 29, 2018

Merge pull request #48368 from asenci/fix_48367
Fix issue #48367 using the same approach as PR #46776

gitebra pushed a commit to gitebra/salt that referenced this pull request Jun 29, 2018

Merge remote-tracking branch 'upstream/develop' into develop
* upstream/develop: (26 commits)
  Fix issue saltstack#48367 using the same approach as PR saltstack#46776
  Changing debug to info for logging
  Update glusterfs test case
  Netmiko module: enhance the behaviour for a more flexible commit arg
  Use the right ssh key to destroy kitchen
  Enhance the NAPALM validator function to render (remote) SLS files
  Fix tuple element to be int
  Fix unit tests
  Add warnings plugin to replace violations
  Remove In Progress Warning for 2018.3.2 Release
  Update release versions for the develop branch
  Fix missing parentheses
  Fix GlusterFS module for version 4.0 and above
  Add backward-compatibility for older python-consul package dependencies
  Add new netmiko and junos functions to the napalm module
  3rd times the charm for Sphinx?
  Documentation change
  Fix PEP8 E302 lint issues
  Post code review alterations

rallytime added a commit to rallytime/salt that referenced this pull request Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment