New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression to ignore retcodes on crontab calls #46824

Merged
merged 3 commits into from Apr 3, 2018

Conversation

Projects
None yet
4 participants
@beornf
Contributor

beornf commented Apr 3, 2018

What does this PR do?

Ensures there is no error logging if the crontab doesn't exist.

What issues does this PR fix or reference?

#46439

Previous Behavior

Salt errors while checking for user crontab, then the state advises it ran successfully without installing a crontab.

New Behavior

Salt checks for user crontab, if present, done, if not present, install the users crontab.

Tests written?

No

Commits signed with GPG?

Yes

beornf added some commits Apr 3, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 3, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 3, 2018

re-run py

@rallytime rallytime merged commit 0d8a035 into saltstack:develop Apr 3, 2018

6 of 10 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #3700 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21425 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17743 — RUNNING
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23857 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16023 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #8488 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #20642 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment