Follow up Kapacitor module enhancements.#46825
Merged
cachedout merged 5 commits intosaltstack:developfrom Apr 16, 2018
Merged
Conversation
Contributor
|
@aabouzaid This PR has some lint errors: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/20623/violations/ |
cachedout
approved these changes
Apr 3, 2018
Contributor
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
Approved pending the lint errors being fixed.
aabouzaid
force-pushed
the
kapacitor_enhancements
branch
from
4c4cdfd to
20f4be7
Compare
aabouzaid
commented
Apr 4, 2018
|
|
||
| salt '*' kapacitor.define_task cpu salt://kapacitor/cpu.tick database=telegraf | ||
| ''' | ||
| if not database and not dbrps: |
Contributor
Author
There was a problem hiding this comment.
@cachedout Since we cannot change the parameter directly from optional to mandatory to avoid breaking anything, what do you think about this approach? 🤔
Contributor
There was a problem hiding this comment.
If we do this we should also log an error with log.error() IMHO
rallytime
approved these changes
Apr 9, 2018
Contributor
|
re-run py |
Contributor
|
@aabouzaid It looks like your change is causing the following test to fail:
Can you take a look? |
Contributor
|
Bump @aabouzaid. Will you be able to investigate the failing test? |
Contributor
Author
|
@cachedout I'm checking it right now, thanks. |
Contributor
Author
|
@cachedout everything looks fine now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
A follow up for #46294
Previous Behavior
Database name was set to
Nonewhere it was producing an error.New Behavior
Database name is a mandatory field.
Tests written?
No need.
Commits signed with GPG?
Yes