-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make raw imports from _utils work #46841
Make raw imports from _utils work #46841
Conversation
357eddb
to
1c26f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would not be a good idea, it would add utils functions to both __salt__
and __states__
.
Can you show an example of what you're trying to do, what you expect to happen, and what is happening instead? Your most recent comment in the linked issue doesn't really offer much information.
I'm trying to make the following example from the doc work:
In v2017.7.3 it fails with an |
OK, I'm not familiar with this functionality, I will investigate. |
I see now what you meant in your comment:
I did not use those states when I tested the patch, so it looked okay. |
We definitely don't want to merge this. I'm going to close this but we can discuss a path forward in #32500. |
No problem, let's discuss the possible alternatives there. |
This is a quick hack to make it work with salt-ssh.
It would be great if anyone could outline the proper solution, since I got lost in module loading logic.
What issues does this PR fix or reference?
#32500
Previous Behavior
Importing
_utils
module resulted inImportError
.New Behavior
Importing
_utils
module works as described in https://docs.saltstack.com/en/latest/topics/utils/index.htmlTests written?
No
Commits signed with GPG?
Yes