Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return TLS cert expiration date #46922

Merged
merged 3 commits into from Apr 19, 2018

Conversation

@terminalmage
Copy link
Collaborator

@terminalmage terminalmage commented Apr 6, 2018

Refs: #7424

Copy link
Contributor

@cachedout cachedout left a comment

Nice!

@cachedout
Copy link
Contributor

@cachedout cachedout commented Apr 6, 2018

Tests though?

@terminalmage
Copy link
Collaborator Author

@terminalmage terminalmage commented Apr 6, 2018

I tested on an openvpn TLS cert, I didn't create a separate one specifically for a test, but I can.

@cachedout
Copy link
Contributor

@cachedout cachedout commented Apr 9, 2018

I'm thinking of automated tests here. Is that what you were suggesting you would create? Or just testing manually on another cert?

@terminalmage
Copy link
Collaborator Author

@terminalmage terminalmage commented Apr 11, 2018

Yeah, I was thinking of automated tests, I just need to create a cert for the purposes of writing such a test, since I don't want to use my openvpn certs for a test.

@terminalmage
Copy link
Collaborator Author

@terminalmage terminalmage commented Apr 19, 2018

Unit test added.

@rallytime
Copy link
Contributor

@rallytime rallytime commented Apr 19, 2018

re-run centos

@rallytime rallytime merged commit 2d935be into saltstack:develop Apr 19, 2018
5 of 10 checks passed
@terminalmage terminalmage deleted the issue7424 branch Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants