Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return TLS cert expiration date #46922

Merged
merged 3 commits into from
Apr 19, 2018

Conversation

terminalmage
Copy link
Contributor

Refs: #7424

Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cachedout
Copy link
Contributor

Tests though?

@terminalmage
Copy link
Contributor Author

I tested on an openvpn TLS cert, I didn't create a separate one specifically for a test, but I can.

@cachedout
Copy link
Contributor

I'm thinking of automated tests here. Is that what you were suggesting you would create? Or just testing manually on another cert?

@terminalmage
Copy link
Contributor Author

Yeah, I was thinking of automated tests, I just need to create a cert for the purposes of writing such a test, since I don't want to use my openvpn certs for a test.

@terminalmage terminalmage added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Apr 16, 2018
@terminalmage
Copy link
Contributor Author

Unit test added.

@terminalmage terminalmage added Has Testcase and removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Apr 19, 2018
@rallytime
Copy link
Contributor

re-run centos

@rallytime rallytime merged commit 2d935be into saltstack:develop Apr 19, 2018
@terminalmage terminalmage deleted the issue7424 branch April 20, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants