Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return TLS cert expiration date #46922

Merged
merged 3 commits into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Apr 6, 2018

Refs: #7424

@cachedout
Copy link
Collaborator

left a comment

Nice!

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2018

Tests though?

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

I tested on an openvpn TLS cert, I didn't create a separate one specifically for a test, but I can.

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2018

I'm thinking of automated tests here. Is that what you were suggesting you would create? Or just testing manually on another cert?

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2018

Yeah, I was thinking of automated tests, I just need to create a cert for the purposes of writing such a test, since I don't want to use my openvpn certs for a test.

terminalmage added some commits Apr 6, 2018

@terminalmage terminalmage force-pushed the terminalmage:issue7424 branch from f672386 to d7bfd13 Apr 19, 2018

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2018

Unit test added.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2018

re-run centos

@rallytime rallytime merged commit 2d935be into saltstack:develop Apr 19, 2018

5 of 10 checks passed

default Pull Requests » Salt PR - Main Build - PY2/PY3 #7976
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18255 — ABORTED
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4206 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #21988 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9053 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24373 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16516 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21135 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:issue7424 branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.