New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for not being prompted to supply a password to deploy keys to a… #47100

Merged
merged 2 commits into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@gtmanfred
Contributor

gtmanfred commented Apr 16, 2018

What does this PR do?

… minion with salt-ssh

What issues does this PR fix or reference?

Fixes #47087

Tests written?

No

Commits signed with GPG?

Yes

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Apr 17, 2018

re-run py

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 17, 2018

@gtmanfred A quick test here would be good to have.

@gtmanfred gtmanfred force-pushed the gtmanfred:ssh branch 3 times, most recently from 956c5ea to b1be2ac May 31, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 19, 2018

@gtmanfred Bump :)

Can you write a test for this really quickly?

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 19, 2018

I tried to write tests, but I was unable to get the tests to fail to login to the localhost minion in the roster in the tests.

I need to spend more time looking at it at some point.

@gtmanfred gtmanfred closed this Jun 27, 2018

@gtmanfred gtmanfred reopened this Jun 27, 2018

gtmanfred added some commits Apr 16, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:ssh branch from 1ff4f21 to 5b443af Jul 31, 2018

@rallytime rallytime merged commit 2421e2a into saltstack:2017.7 Aug 5, 2018

6 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@gtmanfred gtmanfred deleted the gtmanfred:ssh branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment