Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[2018.3] Strip trailing commas on Linux user's GECOS fields #47149
What does this PR do?
This PR strips the trailing commas (if any) created when the user GECOS fields (comma-delimited list) are generated by the
Given this example state:
create_my_test_user: user.present: - name: testuser - fullname: Testing User
After applying the state, the generated entry on
Most of the times, the users are defined without
On this cases the usual representation should be like:
So, after applying this PR, the entry generated on
Commits signed with GPG?
@cachedout should this be treated as a bug and included in 2018.3.1? My concern is that people who have
@terminalmage - AFAIK this change wouldn't produce any change on a
I agree with you that this is more like a cosmetic change than a bug itself.
Oh, wait! I just noticed that
Now we call
I'll do the necessary changes here and will ping you back for a review.
I pushed new commits to this PR to enable handling the
Now, all extra GECOS fields are handled as an independent
Btw, I added 795b380 which actually fixes a bug which prevents checking if the GECOS fields contains unsupported characters.
@meaksh These test failures are related to this change: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22849/#showFailuresLink
Can you take a look?