Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitfs support for Thorium #47187

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
5 participants
@azelezni
Copy link
Contributor

commented Apr 19, 2018

What does this PR do?

Allow thorium to use gitfs with a mountpoint or saltenv.

What issues does this PR fix or reference?

Fixes #47119

Alex Zeleznikov
Add gitfs support for Thorium
Allow thorium to use gitfs with a mountpoint or saltenv.
Fixes #47119

@azelezni azelezni requested a review from saltstack/team-core as a code owner Apr 19, 2018

@terminalmage
Copy link
Contributor

left a comment

This makes sense but I'd also like @thatch45 to give it a look.

Update __init__.py
Fix thoriumenv valid values
@mirceaulinic
Copy link
Member

left a comment

Very nice, thanks!

@rallytime rallytime requested a review from thatch45 Apr 23, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-core Apr 23, 2018

@thatch45

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

Wow, thats it! We should all pat ourselves on the back for good design on this one since it was so easy to get this added in.
I will also sit embarrassed that I neglected to add this in when it was so easy to do!

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2018

Welcome @azelezni! And thank you for fixing this. :)

@rallytime rallytime merged commit 706b9b7 into saltstack:develop Apr 23, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18281 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4232 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22021 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9086 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24399 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16541 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21160 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.