Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitfs support for Thorium #47187

Merged
merged 2 commits into from Apr 23, 2018
Merged

Add gitfs support for Thorium #47187

merged 2 commits into from Apr 23, 2018

Conversation

azelezni
Copy link
Contributor

What does this PR do?

Allow thorium to use gitfs with a mountpoint or saltenv.

What issues does this PR fix or reference?

Fixes #47119

Allow thorium to use gitfs with a mountpoint or saltenv.
Fixes #47119
@azelezni azelezni requested a review from a team as a code owner April 19, 2018 18:27
Copy link
Contributor

@terminalmage terminalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense but I'd also like @thatch45 to give it a look.

Fix thoriumenv valid values
Copy link
Contributor

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@rallytime rallytime requested a review from thatch45 April 23, 2018 13:18
@ghost ghost self-requested a review April 23, 2018 13:18
@thatch45
Copy link
Member

Wow, thats it! We should all pat ourselves on the back for good design on this one since it was so easy to get this added in.
I will also sit embarrassed that I neglected to add this in when it was so easy to do!

@rallytime
Copy link
Contributor

Welcome @azelezni! And thank you for fixing this. :)

@rallytime rallytime merged commit 706b9b7 into saltstack:develop Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thorium reactor not working
5 participants