New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boto_ec2 unused parameter "network_interfaces" #47221

Merged
merged 2 commits into from May 29, 2018

Conversation

Projects
None yet
2 participants
@azelezni
Contributor

azelezni commented Apr 21, 2018

What does this PR do?

Allow using network_interfaces parameter with boto_ec2.instance_present state module.

Fix unused network_interfaces parameter
When using the boto_ec2.instance_present state module,
network_interfaces parameter was not used.

@salt-jenkins salt-jenkins requested a review from saltstack/team-boto Apr 21, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 23, 2018

Hi @azelezni and welcome!

There are some lint errors on this change: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/21184/violations/file/salt/modules/boto_ec2.py/

The PY3 compatibility errors have suggested fixes in the "console" output link: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/21184/console

Can you fix those?

Fix unused network_interfaces parameter
When using the boto_ec2.instance_present state module,
network_interfaces parameter was not used.
@rallytime

Thank you @azelezni - this looks good to me.

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 22, 2018

@ryan-lane Do you want to look this one over?

@rallytime rallytime merged commit 61561a8 into saltstack:2018.3 May 29, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18330 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4279 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24448 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16590 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22081 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9139 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21209 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment