-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix issue #38366 salt-ssh support private key's passphrase #47238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add docs about this config option to the salt ssh topics page?
Also, adding this to the release notes for Fluorine would be greatly appreciated. |
doc/man/salt-ssh.1
Outdated
@@ -177,6 +177,11 @@ Specify the SSH private key file to be used for authentication. | |||
.UNINDENT | |||
.INDENT 0.0 | |||
.TP | |||
.B \-\-priv\-passwd=SSH_PRIV_PASSWD | |||
Specify the SSH private key file's passphrase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this change?
We compile these when they are packaged, it does not need to be updated.
It will be updated when packaged
This change is causing many of the ssh tests to fail. @pengyao Can you take a look? |
@rallytime It's my fault. I have fixed it. |
@pengyao Looks like one more test here needs to be addressed :) https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22289/ |
@pengyao Are you able to resolve that final failing test? We would really like to get this merged if we can. :) |
@cachedout @rallytime Jenkins Error is:
I think the error is not created by this commits |
re-run py |
@rallytime merge into develop branch? |
@pengyao The following test is still failing:
That will need to be fixed before we can merge this in. https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/23028/ |
Thanks for fixing that @pengyao - that looks good. I think an addition to the release notes (for Fluorine) would be good here as well. Can you add something for that? Then we can get this in :) |
@pengyao We just need this added to the Fluorine release notes and then we can get this in. |
@rallytime The addition is added to the Fluorine release notes |
@pengyao Oh! You're right. I thought I double checked but I must have missed it. Thank you! |
What does this PR do?
Fix issue #38366
What issues does this PR fix or reference?
Support private key's passphrase for salt-ssh
Previous Behavior
Not support
New Behavior
Private key's passphrase could be configured by:
--priv-passwd
for salt-ssh clisalt_priv_passwd
for salt master configure filepriv_passwd
for salt roster file