Fix issue #38366 salt-ssh support private key's passphrase

[pengyao]

What does this PR do?

Fix issue #38366

What issues does this PR fix or reference?

Support private key's passphrase for salt-ssh

Previous Behavior

Not support

New Behavior

Private key's passphrase could be configured by:

• --priv-passwd for salt-ssh cli
• salt_priv_passwd for salt master configure file
• priv_passwd for salt roster file

[gtmanfred]

Can you add docs about this config option to the salt ssh topics page?

[gtmanfred]

Also, adding this to the release notes for Fluorine would be greatly appreciated.

[gtmanfred]

Can you remove this change?

We compile these when they are packaged, it does not need to be updated.

[rallytime]

This change is causing many of the ssh tests to fail. @pengyao Can you take a look?

[pengyao]

@rallytime It's my fault. I have fixed it.

[rallytime]

@pengyao Looks like one more test here needs to be addressed :)

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22289/

[cachedout]

@pengyao Are you able to resolve that final failing test? We would really like to get this merged if we can. :)

[pengyao]

@cachedout @rallytime Jenkins Error is:

No test reports found for the metric 'JUnit' with the resolved pattern 'artifacts/unittests/*.xml'. Configuration error?.

I think the error is not created by this commits

[rallytime]

re-run py

[pengyao]

@rallytime merge into develop branch?

[rallytime]

@pengyao The following test is still failing:

• unit.config.schemas.test_ssh.RosterEntryConfigTest.test_config

That will need to be fixed before we can merge this in.

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/23028/

[rallytime]

Thanks for fixing that @pengyao - that looks good.

I think an addition to the release notes (for Fluorine) would be good here as well. Can you add something for that? Then we can get this in :)

[rallytime]

@pengyao We just need this added to the Fluorine release notes and then we can get this in.

[pengyao]

@rallytime The addition is added to the Fluorine release notes

[rallytime]

@pengyao Oh! You're right. I thought I double checked but I must have missed it. Thank you!