event.send add option for return to not show as change#47391
event.send add option for return to not show as change#47391rallytime merged 16 commits intosaltstack:developfrom
Conversation
|
If we're going to do this we need to modify this PR so that information about this change is added to the release notes first, please. |
twellspring
changed the title
|
Hi @twellspring. We need the release notes modified and also these lint errors fixed before we can merge this. Thanks! https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/21472/violations/file/salt/states/event.py/ |
|
@twellspring Will you be able to make the requested changes to this? If not we'll go ahead and close it. Thanks. |
|
Just getting back to this PR. I'll update it soon |
|
Took care of the linting problems I could. Added release notes. I could not find any document saying best practices for the release notes, so made my best guess. |
| create a LocalClient connection to the master ipc sockets to control | ||
| environments. | ||
|
|
||
| Sent events can return as unchanged |
There was a problem hiding this comment.
Since this addition is going into develop, this release note change should go into the Fluorine.rst file instead of 2018.3.1.
|
@rallytime moved the release notes per your request. These commits were by me and not jenniparcell ... I was testing how easy it was to spoof another user and forgot to remove it. Fixed that and detting up GPG for myself. |
| **kwargs): | ||
| data=None, | ||
| preload=None, | ||
| show_changed=True, |
There was a problem hiding this comment.
Are we calling this function positionally anywhere in salt? It'd probably be better to move this to the bottom of the list, just in case?
|
@rallytime done |
5 participants
What does this PR do?
Adds a
show_changedoption to the event.send state. The default ( true ) has same behavior as before ( putting the data parameter into the changes return value). Setting to false sets the changes return value to {} so that the state does not show as a change.Using this parameter allows for cleaning up the highstate return so it is easier to see the actual changes on the minion.
What issues does this PR fix or reference?
#43914
New Behavior
show_change: Falsechanges the event.send return from True with changes to True no changesTests written?
No
Commits signed with GPG?
No