New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip status.diskusage integration tests on macsox #47408

Merged
merged 3 commits into from May 7, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented Apr 30, 2018

What does this PR do?

The execution modules status.diskusage currently only returns {} on macosx because there is no logic in the code currently to support this operating system. Skipping the test for now until functionality is added for mac.

What issues does this PR fix or reference?

saltstack/salt-jenkins#939

@@ -44,6 +44,7 @@ def test_status_saltmem(self):
ret = self.run_function('status.saltmem')
self.assertTrue(isinstance(ret, int))
@skipIf(salt.utils.is_darwin(), 'status.diskusage not currently supported on macosx')

This comment has been minimized.

@cachedout

cachedout Apr 30, 2018

Contributor

Is the module itself properly accounting for this and returning an appropriate warning? If not, shouldn't it be?

This comment has been minimized.

@Ch3LL

Ch3LL May 1, 2018

Contributor

agreed it should return an error. Currently it just returns {} if its not supported. Will add a warning.

Ch3LL and others added some commits May 1, 2018

@rallytime rallytime merged commit e9c1723 into saltstack:2017.7 May 7, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4716 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9663 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18771 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24891 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17011 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22625 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21631 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment