Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing test=False as kwarg from orchestration file to minion in permanent test mode #47427

Merged

Conversation

Projects
None yet
2 participants
@Tanoti
Copy link
Contributor

commented May 2, 2018

What does this PR do?

Enables passing test mode=False as kwarg from orchestration file down to minion so as to override a minion with test:True enabled in the config file.

NOTE: This is a re-implementation of #45253 as that one got horribly messed up after a rebase.

What issues does this PR fix or reference?

#24209

Previous Behavior

Minion would ignore the test mode override and execute states in test mode regardless.

New Behavior

Minion now receives and uses the test=False override from the orchestration file.

Tests written?

No

Commits signed with GPG?

No

@rallytime rallytime merged commit 28c8520 into saltstack:develop May 2, 2018

6 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4593 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9517 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18645 — ABORTED
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24765 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16893 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22472 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21513 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.