Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing test=False as kwarg from orchestration file to minion in permanent test mode #47427

Merged

Conversation

@Tanoti
Copy link
Contributor

@Tanoti Tanoti commented May 2, 2018

What does this PR do?

Enables passing test mode=False as kwarg from orchestration file down to minion so as to override a minion with test:True enabled in the config file.

NOTE: This is a re-implementation of #45253 as that one got horribly messed up after a rebase.

What issues does this PR fix or reference?

#24209

Previous Behavior

Minion would ignore the test mode override and execute states in test mode regardless.

New Behavior

Minion now receives and uses the test=False override from the orchestration file.

Tests written?

No

Commits signed with GPG?

No

@rallytime rallytime merged commit 28c8520 into saltstack:develop May 2, 2018
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants