Enable passing test=False as kwarg from orchestration file to minion in permanent test mode#47427
Merged
rallytime merged 2 commits intoMay 2, 2018
Merged
Enable passing test=False as kwarg from orchestration file to minion in permanent test mode#47427rallytime merged 2 commits into
rallytime merged 2 commits into
Conversation
…in permanent test mode
rallytime
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables passing test mode=False as kwarg from orchestration file down to minion so as to override a minion with test:True enabled in the config file.
NOTE: This is a re-implementation of #45253 as that one got horribly messed up after a rebase.
What issues does this PR fix or reference?
#24209
Previous Behavior
Minion would ignore the test mode override and execute states in test mode regardless.
New Behavior
Minion now receives and uses the test=False override from the orchestration file.
Tests written?
No
Commits signed with GPG?
No