New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip trying to render a template for a nonexistant SLS file #47444

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Member

terminalmage commented May 3, 2018

This skips an unnecssary call to compile_template, and also prevents a confusing error message: "Template was specified incorrectly: False", for cases when an SLS target specified in a top file does not exist.

Skip trying to render a template for a nonexistant SLS file
This skips an unnecssary call to compile_template, and also prevents a
confusing error message: "Template was specified incorrectly: False",
for cases when an SLS target specified in a top file does not exist.

@salt-jenkins salt-jenkins requested a review from saltstack/team-state May 3, 2018

@cachedout cachedout merged commit 7f53be6 into saltstack:2017.7 May 7, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9547 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18669 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24789 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16916 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4617 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22503 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21536 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:render_state-spurious-error branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment