New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont reset system locale when running rabbitmqctl commands #47453

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
5 participants
@dqminh
Contributor

dqminh commented May 3, 2018

Fix #45383

Observe the errors with rabbitmq 3.7.3.

ERROR: RabbitMQ command failed: warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8.
Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)

cc @gtmanfred

@dqminh dqminh force-pushed the dqminh:rabbitmq/stretch branch from 176d315 to f3869b9 May 3, 2018

@dqminh

This comment has been minimized.

Contributor

dqminh commented May 3, 2018

@gtmanfred not sure about codeclimate complaints, should i care ?

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 3, 2018

Nah, it is just complaining about doc strings.

We haven't really tuned it yet.

dont reset system locale when running rabbitmqctl commands
Observe the errors with rabbitmq 3.7.3.
```
ERROR: RabbitMQ command failed: warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8.
Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)
```

@dqminh dqminh force-pushed the dqminh:rabbitmq/stretch branch from f3869b9 to d0e33f7 May 4, 2018

@cachedout cachedout merged commit 6086ee4 into saltstack:develop May 7, 2018

4 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4663 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9601 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18718 — ABORTED
Details
codeclimate 12 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22561 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24838 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16959 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21579 — SUCCESS
Details

@dqminh dqminh deleted the dqminh:rabbitmq/stretch branch May 18, 2018

rallytime added a commit that referenced this pull request Jun 25, 2018

@L4rS6

This comment has been minimized.

Contributor

L4rS6 commented Jul 12, 2018

In which 2018.3.x release will this be fixed? In 2018.3.2 it's still not fixed.

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 12, 2018

2018.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment