New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows timeout to run_salt #47493

Merged
merged 1 commit into from May 6, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented May 5, 2018

What does this PR do?

Adds support for run_sat timeouts on windows.

The run_salt function needs to support timeout on windows for the full
test suite to run.

Tests written?

No - Enables multiple tests to run without Exceptions

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred May 5, 2018

@dwoz dwoz force-pushed the dwoz:win_run_timeout branch from 1cb55bc to c1afd84 May 5, 2018

Add support for windows timeout to run_salt
The run_salt function needs to support timeout on windows for the full
test suite to run.

@dwoz dwoz force-pushed the dwoz:win_run_timeout branch from c1afd84 to fec1233 May 5, 2018

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 6, 2018

re-run py2

@dwoz dwoz merged commit 6a4d038 into saltstack:2017.7 May 6, 2018

5 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4691 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22594 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18746 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24866 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16987 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9633 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21607 — SUCCESS
Details
@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 7, 2018

@dwoz does this need to be added to 2017.7.6?

@dwoz dwoz deleted the dwoz:win_run_timeout branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment