New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kill process tree and re-use it #47499

Merged
merged 1 commit into from May 6, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented May 6, 2018

What does this PR do?

Handle another case where the test suite needs to time out a subprocess on Windows.

Tests written?

No - Fixes existing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred May 6, 2018

@gtmanfred gtmanfred merged commit 0d4d504 into saltstack:2017.7 May 6, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4697 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9639 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18752 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24872 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #16992 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22600 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21612 — SUCCESS
Details
@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 7, 2018

@dwoz does this need to be added to 2017.7.6?

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 7, 2018

@gtmanfred This is some preparatory work for when we run the windows suite without whitelist.txt. This won't affect anything in the 2017.7.6 branch.

@dwoz dwoz deleted the dwoz:win_run_timeout_again branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment