New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the current username on windows #47500

Merged
merged 4 commits into from May 24, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Contributor

dwoz commented May 6, 2018

What does this PR do?

Get the current username on windows, required for some tests to run.

Tests written?

No - Fixes existing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred May 6, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 6, 2018

@dwoz dwoz force-pushed the dwoz:winuser branch from d1a8d76 to 88f3658 May 6, 2018

@dwoz dwoz changed the title from Get the current username on windows to WIP: Get the current username on windows May 6, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 15, 2018

@dwoz Were you able to fix the lint violations here? This will need a rebase as well as there is a merge-conflict.

dwoz added some commits May 6, 2018

@dwoz dwoz force-pushed the dwoz:winuser branch from 9a009c1 to a056a29 May 23, 2018

@dwoz dwoz changed the title from WIP: Get the current username on windows to Get the current username on windows May 23, 2018

@dwoz dwoz force-pushed the dwoz:winuser branch from 3ed84d6 to 5331fab May 24, 2018

@dwoz dwoz force-pushed the dwoz:winuser branch from 5331fab to e594890 May 24, 2018

@dwoz dwoz requested a review from rallytime May 24, 2018

@dwoz dwoz merged commit 9342095 into saltstack:2017.7 May 24, 2018

7 of 9 checks passed

default Pull Requests » Salt PR - Main Build - PY2/PY3 #8992
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19298 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25432 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17520 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5242 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23176 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10212 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22150 — SUCCESS
Details

@dwoz dwoz deleted the dwoz:winuser branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment