New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise proper invocation errors #47505

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
4 participants
@dwoz
Contributor

dwoz commented May 6, 2018

What does this PR do?

Raise proper invocation errors

What issues does this PR fix or reference?

#47443

Previous Behavior

Multiple exceptions were instantiated but not raised

New Behavior

Raise exceptions when needed

Tests written?

No

Commits signed with GPG?

Yes

@dwoz dwoz requested review from garethgreenaway and twangboy May 6, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows May 6, 2018

@dwoz dwoz force-pushed the dwoz:win_dsc_fixes branch from 9a4b296 to d1fcb40 May 6, 2018

@cachedout cachedout merged commit e78ac0f into saltstack:2017.7 May 7, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4705 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18760 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24880 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17000 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22608 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9647 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21620 — SUCCESS
Details
@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 7, 2018

@dwoz does this need to be added to 2017.7.6?

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 7, 2018

@gtmanfred yes, this one should go to 2017.7.6 since it's a bug.

rallytime added a commit that referenced this pull request May 7, 2018

@dwoz dwoz deleted the dwoz:win_dsc_fixes branch May 7, 2018

rallytime added a commit that referenced this pull request May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment