New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svn export invalid changes data #47510

Merged
merged 3 commits into from May 7, 2018

Conversation

Projects
None yet
3 participants
@daa
Contributor

daa commented May 7, 2018

What does this PR do?

This pull request fixes invalid "changes" data reported by svn.export state - currently it is string but must be dictionary.

What issues does this PR fix or reference?

#21025, #40004

Previous Behavior

svn.export changes data is string which is invalid and results in failing state.

New Behavior

Now data under "changes" key is dictionary.

Tests written?

Yes

Commits signed with GPG?

No

@rallytime rallytime merged commit 172559c into saltstack:develop May 7, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4718 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9665 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18773 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22627 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24893 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17013 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21633 — SUCCESS
Details

@daa daa deleted the daa:fix-svn-export-invalid-changes-data branch May 7, 2018

@daa

This comment has been minimized.

Contributor

daa commented Jul 20, 2018

Would you please merge this patch into 2018.3 branch because this is a bugfix. I'm sorry for bothering you but I need this bugfix in some of the folowing releases.

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jul 20, 2018

@daa Sure thing. I've marked it for back-porting.

rallytime added a commit that referenced this pull request Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment