Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #46546 eos napalm's grains issue #47513

Merged
merged 2 commits into from May 8, 2018

Conversation

Projects
None yet
3 participants
@frankiexyz
Copy link
Contributor

commented May 7, 2018

What does this PR do?

For eos minion (not proxy minon), grains are not able to retrieve due to connection is not opened.
By changing the device cache update to function get_device, it will setup a connection first.

What issues does this PR fix or reference?

#46546
#47203

Previous Behavior

➜ docker exec -t d03bd4c21b37 salt '*' grains.get vendor
supervisor1:
None

New Behavior

➜ docker exec -t d03bd4c21b37 salt '' grains.get hostname
test:
test
➜ docker exec -t d03bd4c21b37 salt '
' grains.get vendor
test:
Arista
After change hostname to test2
➜ frankie docker exec -t d03bd4c21b37 salt '' saltutil.refresh_grains
test:
True
➜ docker exec -t d03bd4c21b37 salt '
' grains.get hostname
test:
test2

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Frankie Hui
@frankiexyz

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2018

@mirceaulinic
Copy link
Member

left a comment

Thanks @frankiexyz

@rallytime rallytime merged commit 4097114 into saltstack:develop May 8, 2018

6 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4746 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18801 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22659 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24921 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17040 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9697 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21660 — SUCCESS
Details

rallytime added a commit that referenced this pull request May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.