New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle blank lines in whitelist.txt #47524

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Contributor

dwoz commented May 7, 2018

What does this PR do?

Handle the case of having extra spaces and/or a blank lines in whitelist.txt. This can happen if one manually edits whitelist.txt during development. In those cases the test suite ends with an Exception which can be fairly annoying.

Commits signed with GPG?

Yesgning commits with GPG.

@dwoz dwoz requested a review from gtmanfred May 7, 2018

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 7, 2018

re-run py

@cachedout cachedout merged commit 7cc8d9d into saltstack:2017.7 May 8, 2018

5 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9695 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4744 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18799 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24919 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17032 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22657 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21652 — SUCCESS
Details

@dwoz dwoz deleted the dwoz:whitelistlines branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment