New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add a duplicate sec group rule true #47525

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@baniobloom
Contributor

baniobloom commented May 7, 2018

What does this PR do?

If we are trying to a duplicate security group rule, then we are already in the desired state, return true

What issues does this PR fix or reference?

If we are trying to a duplicate security group rule, then we are already in the desired state, return true

Previous Behavior

Error with:
[ERROR ] Failed to add rule to security group default with id sg-xxxxxxxxxx.
[ERROR ] EC2ResponseError: 400 Bad Request

InvalidPermission.Duplicatethe specified rule "peer: 10.x.x.x/xx, TCP, from port: xxx, to port: xxx, ALLOW" already existsxxxxxxxx
[ERROR ] {u'ret': False}

New Behavior

If we are trying to a duplicate security group rule, then we are already in the desired state, return true

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@salt-jenkins salt-jenkins requested a review from saltstack/team-boto May 7, 2018

@cachedout

This comment has been minimized.

Contributor

cachedout commented May 8, 2018

@ryan-lane Did you want to look at this?

@rallytime

LGTM

@rallytime rallytime merged commit 9c5dde1 into saltstack:2017.7 May 22, 2018

6 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4740 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18795 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #24915 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17035 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22651 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9690 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21655 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment