New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Sysloghandler errors when log file does not exist #47548

Merged
merged 2 commits into from May 10, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented May 8, 2018

What issues does this PR fix or reference?

#47432
saltstack/salt-jenkins#936

Previous Behavior

In python3 this PR was added python/cpython#663 which makes sure it just passes when there is an OSERROR. The problem is when running salt with a log_file set to file://doesnotexist or syslog service hasn't started yet it prints the entire traceback and is hard to digest.

New Behavior

Prints out a new warning: [WARNING ] The log_file does not exist. Logging not setup correctly or syslog service not started.

Tests written?

Yes

Commits signed with GPG?

Yes

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 9, 2018

re-run py3

@rallytime

Really nice work tracking this one down. 👍

@Ch3LL Ch3LL requested a review from s0undt3ch May 9, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 9, 2018

@Ch3LL Looks like the new test you wrote is failing on PY3.

@rallytime rallytime merged commit 8a7913c into saltstack:2017.7 May 10, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4823 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18879 — RUNNING
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25000 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17113 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22755 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9792 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21733 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment