Join GitHub today
[2018.3] archive module, filenames with Unicode characters #47572
What does this PR do?
Accounting for when files in an archive contain non-ascii characters
What issues does this PR fix or reference?
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
@garethgreenaway The archive state integration tests didn't like this change very much: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-cent7-py3/4803/
Can you take a look?
There are a few places that this fix can be simplified.
May 17, 2018
May 17, 2018
4 of 9 checks passed
@garethgreenaway I'm seeing a backtrace two lines down from this change on a specific file with unicode characters. I've applied this changeset on top of 2018.3.0 and you can repro the failure with this state:
You have much more experience on this than I do and I'd be glad to help you reproduce it and validate a fix. Shall we move this to a new issue and continue some troubleshooting?
@junovitch No need for a new issue, we can just re-open the existing issue and reference the new PR in there. I believe I've got this one figured out. The issue is over in the archive module, here is a diff if you wouldn't mind testing it for me:
If everything looks good then I'll prep a new PR. Thanks!
@garethgreenaway thanks for the quick work. This is an improvement; the tar file now doesn't hit that uncaught exception. Both the tar and zip in the referenced sls snippet above fail at the same point:
What do you think? Let me know and I will sanity check things. Certainly tag me in the new PR when we get there as well. Thanks!
edit I will note that I have only applied the one pull request on top of 2018.3.0 and I did see in the work in progress changelog there are several more unicode related items. So this could be resolved with work elsewhere.