New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mac_service.disabled is correctly querying services #47578

Merged
merged 4 commits into from May 15, 2018

Conversation

Projects
None yet
5 participants
@Ch3LL
Contributor

Ch3LL commented May 9, 2018

What does this PR do?

ensure we are correctly querying the disabled status of a service

What issues does this PR fix or reference?

#47577

Previous Behavior

mac test integration.modules.test_service.ServiceModuleTest.test_service_disable failing

jk-sierra-py3:testing root# salt-call --local service.disable org.ntp.ntpd
local:
    True
jk-sierra-py3:testing root# 
jk-sierra-py3:testing root# salt-call --local service.disabled org.ntp.ntpd
local:
    False
jk-sierra-py3:testing root#

New Behavior

mac test integration.modules.test_service.ServiceModuleTest.test_service_disable passing

jk-sierra-py3:testing root# salt-call --local service.disable org.ntp.ntpd
local:
    True
jk-sierra-py3:testing root# salt-call --local service.disabled org.ntp.ntpd
local:
    True
jk-sierra-py3:testing root# 

Tests written?

Yes

Commits signed with GPG?

Yes

Ch3LL added some commits May 9, 2018

@Ch3LL Ch3LL requested review from twangboy and gtmanfred May 9, 2018

@cachedout

This comment has been minimized.

Contributor

cachedout commented May 10, 2018

re-run py

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 10, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 14, 2018

@Ch3LL The new test_service_disable_doesnot_exist test is still failing on Ubuntu 14: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22763/

@rallytime rallytime merged commit a07a890 into saltstack:2017.7 May 15, 2018

6 of 9 checks passed

default Pull Requests » Salt PR - Main Build - PY2/PY3 #8662
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4916 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #18973 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25103 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17203 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22850 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9886 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21833 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment