New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests when we can not use runas #47601

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
5 participants
@dwoz
Contributor

dwoz commented May 10, 2018

What does this PR do?

Skip tests that require runas when we are running under a limited winrm shell.

Commits signed with GPG?

Yes

@dwoz dwoz requested review from gtmanfred and twangboy May 10, 2018

@dwoz dwoz force-pushed the dwoz:runas_detect branch from a7809df to a48ac26 May 10, 2018

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 11, 2018

re-run py

@dwoz

This comment has been minimized.

Contributor

dwoz commented May 11, 2018

re-run lint

1 similar comment
@rallytime

This comment has been minimized.

Contributor

rallytime commented May 14, 2018

re-run lint

@rallytime

I linted this by hand since the lint run is down. Can you make that change really quickly? Then we can get this in.

salt.utils.win_runas.run_as(
'cmd.exe /c echo 1', 'noexistuser', 'n0existp4ss',
)
except WindowsError as exc: # pylint: disable=E060

This comment has been minimized.

@rallytime

rallytime May 14, 2018

Contributor

Looks like the linter doesn't like E060. You should be able to replace that just with undefined-variable instead.

@dwoz dwoz merged commit 6dd3ab9 into saltstack:2017.7 May 14, 2018

1 of 2 checks passed

default Build started sha1 is merged.
Details
WIP ready for review
Details

rallytime added a commit that referenced this pull request May 15, 2018

rallytime added a commit that referenced this pull request May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment