New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in table outputter due to unicode types #47674

Merged
merged 3 commits into from May 16, 2018

Conversation

Projects
None yet
2 participants
@terminalmage
Member

terminalmage commented May 16, 2018

This ensures that we use the proper justification functions from the unicode type on Python 2, and that we also normalize the input so that we are guaranteed that all strings are unicode types.

It also adds a unit test module, as this outputter did not have test coverage.

BONUS: In the course of writing this test, I found a Python 3 incompatibility (map(None, some_iterable) is not valid usage in Python 3). This PR also fixes that incompatiblity in a way that works in both Python 2 and 3.

Resolves #47587.

terminalmage added some commits May 16, 2018

Fix regression in table outputter due to unicode strings
This ensures that we use the proper justification functions from the
unicode type on Python 2, and that we also normalize the input so that
we are guaranteed that all strings are unicode types.
Fix Python 3 incompatibility in table outputter
`map(None, some_iterable)` is not valid usage in Python 3. This fixes
that incompatiblity in a way that works in both Python 2 and 3.

@terminalmage terminalmage changed the title from Fix regression in table outputter due to unicode strings to Fix regression in table outputter due to unicode types May 16, 2018

@rallytime rallytime merged commit 0c7439a into saltstack:2018.3 May 16, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19001 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9914 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25131 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17231 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4944 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22878 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21861 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:issue47587 branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment