New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary setUp in states.test_user test for mac #47683

merged 1 commit into from May 17, 2018


None yet
2 participants

Ch3LL commented May 16, 2018

What does this PR do?

Fixes test_user state integration tests for macosx. This setUp is unnecessary because the user is added where needed in the user.present tests. I also believe it might be the cause for some flakiness with the test_user states on macosx. In particular it was causing this test to fail regularly: integration.states.test_user.UserTest.test_user_if_present_with_gid as the user was being created twice and then trying to change the gid caused an expected warning on 2018.3

@rallytime rallytime merged commit fd2d45d into saltstack:2017.7 May 17, 2018

4 of 9 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19013 — ABORTED
default Build finished.
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4956 — FAILURE
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22890 — FAILURE
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9926 — FAILURE
WIP ready for review
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25143 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17243 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21873 — SUCCESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment