Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update regexes for Solaris 'product' grain and copy to 'productname' grain #47691
What does this PR do?
Updates the regexes for detecting the 'product' grain, additionally copies the data to 'productname' to be more consistent with other OSes.
What issues does this PR fix or reference?
Only the 'product' grain is set and in certain circumstances has incorrect data.
Both 'product' and 'productname' grians have data and accurate data should be displayed.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
The code looks fine.
Note however in 2018.3.0 running salt-call --local grains.items does return productname in the grains output (Solaris 11.3 Intel using VirtualBox and Salt 2018.3.0)
productname: smbios: failed to load SMBIOS: No such file or directory
However I believe the issue with smbios failing as been address in the upcoming point release 2018.3.1, But this still will not address the original issue since smbios only works for the global zone.