New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default windows to m1.small for ec2-classic #47692

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Contributor

dwoz commented May 16, 2018

What does this PR do?

Configure ec2 profile default instance type to m1.small, this is needed to launch the instance into ec2-classic.

What issues does this PR fix or reference?

saltstack/salt-jenkins#980

Commits signed with GPG?

Yes

@dwoz dwoz requested review from rallytime and gtmanfred May 16, 2018

@rallytime rallytime merged commit f323799 into saltstack:2017.7 May 17, 2018

4 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4970 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22904 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9940 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19027 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25157 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17257 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21887 — SUCCESS
Details
@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 17, 2018

@rallytime are we ok with this test failing on 2017.7.6 cloud tests or does it need to be backported?

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 18, 2018

@gtmanfred We can backport it, but the cloud tests are still failing so this isn't the only fix needed.

@dwoz Are you still looking into those cloud tests?

rallytime added a commit that referenced this pull request May 18, 2018

rallytime added a commit that referenced this pull request May 18, 2018

@dwoz dwoz deleted the dwoz:win_instance_type branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment