New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elasticsearch.index_template_present with check_definition #47703

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
3 participants
@babs
Contributor

babs commented May 17, 2018

What does this PR do?

Fixes elasticsearch.index_template_present with check_definition

What issues does this PR fix or reference?

Fixes issue #47701

Previous Behavior

Python error expected string or buffer

New Behavior

Works

Tests written?

No

Commits signed with GPG?

No

@rallytime

LGTM

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 17, 2018

@DarkKnightCZ do you want to take a look at this change?

@lukasraska

This comment has been minimized.

Contributor

lukasraska commented May 17, 2018

@rallytime LGTM, seems it got introduced with recent 2018.3 Unicode changes

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 18, 2018

Thanks @babs and @DarkKnightCZ

@rallytime rallytime merged commit 8944d33 into saltstack:develop May 18, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #4986 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #9956 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19043 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22920 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25173 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17273 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21903 — SUCCESS
Details

rallytime added a commit that referenced this pull request May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment