Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Adding group support in the btmp and wtmp beacons. #47711

Merged

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented May 17, 2018

What does this PR do?

Adding group support in the btmp and wtmp beacons.

What issues does this PR fix or reference?

N/A

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

@garethgreenaway Additionally, the static code analyzer here has a number of suggestions about the depth of the control flow branching.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:beacon_btmp_wtmp_group_support branch 2 times, most recently from 42d89bd to 18b88c8 May 20, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented May 24, 2018

The unit.beacons.test_btmp_beacon.BTMPBeaconTestCase.test_match_time test is failing on this PR.

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/23155/

garethgreenaway added some commits May 17, 2018

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:beacon_btmp_wtmp_group_support branch from 337b7c7 to 6d6e688 May 24, 2018

@rallytime rallytime merged commit 6f33e47 into saltstack:develop May 25, 2018

4 of 10 checks passed

jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23181 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10217 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19303 — ABORTED
Details
codeclimate 2 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5247 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25437 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17525 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22155 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.