[develop] Adding group support in the btmp and wtmp beacons.#47711
Merged
rallytime merged 6 commits intosaltstack:developfrom May 25, 2018
Merged
[develop] Adding group support in the btmp and wtmp beacons.#47711rallytime merged 6 commits intosaltstack:developfrom
rallytime merged 6 commits intosaltstack:developfrom
Conversation
Contributor
|
@garethgreenaway This failed some of the beacon tests: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/22944/ |
Contributor
|
@garethgreenaway Additionally, the static code analyzer here has a number of suggestions about the depth of the control flow branching. |
garethgreenaway
force-pushed
the
beacon_btmp_wtmp_group_support
branch
2 times, most recently
from
42d89bd to
18b88c8
Compare
Contributor
|
The https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/23155/ |
…mp vs wtmp typos.
garethgreenaway
force-pushed
the
beacon_btmp_wtmp_group_support
branch
from
337b7c7 to
6d6e688
Compare
rallytime
approved these changes
May 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding group support in the btmp and wtmp beacons.
What issues does this PR fix or reference?
N/A
Tests written?
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.