Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write_raw method to vault module #47712

Merged
merged 3 commits into from May 22, 2018

Conversation

Projects
None yet
4 participants
@slaws
Copy link
Contributor

commented May 17, 2018

What does this PR do?

This is a proposal to add a new method to the vault module.

This method allow to write complex data to the vault by passing a JSON string

Tests written?

No

Commits signed with GPG?

Partially

slaws added some commits May 17, 2018

Add write_raw method to vault module
This method allow to write complex data to the vault

@rallytime rallytime requested review from gtmanfred and dwoz May 18, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

@slaws just some small lint errors https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/21928/violations/file/salt/modules/vault.py/

Need two new lines between all function definitions.

Thanks!
Daniel

@dwoz

dwoz approved these changes May 18, 2018

@rallytime rallytime merged commit 256ad14 into saltstack:develop May 22, 2018

4 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5055 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10025 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19112 — ABORTED
Details
codeclimate 2 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #22989 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25245 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17341 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #21971 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.