add docker proxy minion

[gtmanfred]

What does this PR do?

This proxy minion + executor combo allows for using the docker.call module to run salt modules inside of docker containers.

This also adds the ability to run a highstate on the docker container.

Tests written?

Yes

Commits signed with GPG?

Yes

[terminalmage]

Should the wording here be modified to reference the docker module instead of state?

[gtmanfred]

I am just going to remove the word state because this will actually be referenced as state.apply when called through the docker proxy minion.

[terminalmage]

OK, cool 👍

[rallytime]

@gtmanfred Can you write some tests for this, please?

EDIT: Oh and this should be added to the fluorine release notes, too.

[gtmanfred]

Will do, yeah i need to write at least a test for the highstate, and then will see what I can do about adding a test for the proxy minion tests.

[gtmanfred]

re-run py

[gtmanfred]

Tests should be good now.

[gtmanfred]

re-run py

[rallytime]

@gtmanfred Looks like some dockermod tests are failing on this:

• integration.modules.test_dockermod.DockerCallTestCase.test_docker_call
• integration.modules.test_dockermod.DockerCallTestCase.test_docker_highstate
• integration.modules.test_dockermod.DockerCallTestCase.test_docker_sls

Can you take a look?

Might be worth rebasing as well - there are some old test failures on this PR that have since been fixed on the branch.

EDIT: Those tests look to be failing on PY3 only

[gtmanfred]

re-run py

[rallytime]

@gtmanfred Those 3 tests are still failing after the latest updates.

[gtmanfred]

FInally was able to replicate this.

Looking now.

[gtmanfred]

Aha! i know exactly the problem.

[gtmanfred]

Ok, this has been failing for a while.

It was just not caught, because self.assertTrue was seeing the return of test.ping as true, even though it was just returning a string about not being able to import yaml.

It looks like it is being caused by the changes that were made to making the thing tarball for salt-ssh, by @isbm

       ('ERROR: Traceback (most recent call last):\n'
        '  File "/tmp/salt.docker.2694e1/salt-call", line 27, in <module>\n'
        '    salt_call()\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/scripts.py", line 395, in '
        'salt_call\n'
        '    import salt.cli.call\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/cli/call.py", line 5, in '
        '<module>\n'
        '    import salt.utils.parsers\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/utils/parsers.py", line 27, in '
        '<module>\n'
        '    import salt.config as config\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/config/__init__.py", line 24, '
        'in <module>\n'
        '    import salt.utils.data\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/utils/data.py", line 17, in '
        '<module>\n'
        '    import salt.utils.dictupdate\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/utils/dictupdate.py", line 15, '
        'in <module>\n'
        '    from salt.serializers.yamlex import merge_recursive as '
        '_yamlex_merge_recursive\n'
        '  File "/tmp/salt.docker.2694e1/pyall/salt/serializers/yamlex.py", line '
        '118, in <module>\n'
        '    import yaml\n'
        'ImportError: No module named yaml')

Bo, do you have time to look at this error? I am not sure what the changes were made for using pyall and why it isn't finding the yaml import on python3 versions using docker.call.

Thanks,
Daniel

[isbm]

@gtmanfred oh, interesting. Any hints how to reproduce this? Definitely I am looking into this immediately.

[gtmanfred]

@isbm if you run it with the py3 tests, it just fails, i only had to install the test suite and docker + docker python module.

if you want an automated way, setup kitchen and run bundle exec kitchen test py3-centos-7, but that is probably over kill.

https://kitchen.saltstack.com/docs/file/docs/gettingstarted.md

[gtmanfred]

re-run py3

[gtmanfred]

Docker mod tests are passing

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-cent7-py3/5511/testReport/integration.modules.test_dockermod/DockerCallTestCase/

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu16-py3/10483/testReport/integration.modules.test_dockermod/DockerCallTestCase/