Skip to content

Add file.tidied similar to Puppet's tidy resource.#47718

Merged
rallytime merged 4 commits intosaltstack:developfrom
dhs-rec:add_file_tidied
Aug 5, 2018
Merged

Add file.tidied similar to Puppet's tidy resource.#47718
rallytime merged 4 commits intosaltstack:developfrom
dhs-rec:add_file_tidied

Conversation

@dhs-rec
Copy link
Contributor

@dhs-rec dhs-rec commented May 18, 2018

What does this PR do?

Adds file.tidied as inspired by Puppet

What issues does this PR fix or reference?

Implements #46752

Tests written?

No

Commits signed with GPG?

No

@cachedout
Copy link
Contributor

cachedout commented May 18, 2018

I left some comments in #46752 on this.

gtmanfred
gtmanfred suggested changes May 20, 2018
View reviewed changes
salt/states/file.py Outdated
Copy link
Contributor

@gtmanfred gtmanfred May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use regex instead of fnmatch

Copy link
Contributor Author

@dhs-rec dhs-rec May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rallytime
Copy link
Contributor

rallytime commented May 22, 2018

@dhs-rec Can you write some tests for this new function?

@rallytime rallytime added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label May 22, 2018
@dhs-rec
Copy link
Contributor Author

dhs-rec commented May 24, 2018

Once I manage to wrap my mind around the test stuff...

@rallytime
Copy link
Contributor

rallytime commented May 24, 2018

@dhs-rec Awesome! Thank you!

There's some docs on testing here, if it helps.

@rallytime
Copy link
Contributor

rallytime commented Jul 3, 2018

Hi @dhs-rec - just a bump on this one. Were you able to write some tests for this?

@dhs-rec
Copy link
Contributor Author

dhs-rec commented Jul 9, 2018

No, sorry. Tried last week but I somehow didn't get it (I'm not that experienced in Python hacking). So I would be glad if someone else could jump in...

@rallytime
Copy link
Contributor

rallytime commented Jul 27, 2018

@gtmanfred Do you think you could help out with some tests on this?

@gtmanfred
Copy link
Contributor

gtmanfred commented Jul 27, 2018

Yeah, make an issue and i will work on them 👍

@rallytime rallytime mentioned this pull request Jul 27, 2018
Closed
@gtmanfred
Copy link
Contributor

gtmanfred commented Jul 30, 2018

@dhs-rec i have opened a PR on your branch, once you merge it we should be able to get this PR in.

https://github.com/dhs-rec/salt/pull/1

Thanks,
Daniel

@rallytime rallytime added Fluorine and removed needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Aug 3, 2018
@rallytime rallytime merged commit a2a5876 into saltstack:develop Aug 5, 2018
@dhs-rec
Copy link
Contributor Author

dhs-rec commented Aug 10, 2018

@gtmanfred: Great, thanks a lot!

@dhs-rec dhs-rec deleted the add_file_tidied branch August 10, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gtmanfred gtmanfred gtmanfred approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhs-rec @cachedout @rallytime @gtmanfred