Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restartcheck/opkg: add NILRT "sysapi" reboot support #47722


Copy link

@10ne1 10ne1 commented May 18, 2018

What does this PR do?

Adds reboot detection to restartcheck when NILinuxRT "System API" plugins are installed by the package manager. More details in the commit message & function docstrings.

New Behavior

Restartcheck asks for reboots on NILinuxRT when a new type of packages gets installed.

Tests written?


Commits signed with GPG?


@ghost ghost self-requested a review May 18, 2018
@10ne1 10ne1 force-pushed the dev/aratiu/upstream-nilrt-add-sysapi-reboot-support branch from 610de02 to fb7bda0 May 23, 2018
Ioan-Adrian Ratiu and others added 2 commits May 23, 2018
The code was originally written with only kernel modules triggering
system reboots, but it turns out other components within NILinuxRT
need this functionality, so abstract out the reboot state logic so
it's not kernel-module specific anymore.

The abstracted logic basically functions the same as before: Packages
modify a specific file on disk which gets its md5sum & timestamp
stored under NILRT_RESTARTCHECK_STATE_PATH. The state files in turn
are checked using restartcheck's new  _file_changed_nilrt() function.

Now we just call the generic _file_changed_nilrt() both for kernel
modules and sysapi and anything else we might need in the future.

Signed-off-by: Ioan-Adrian Ratiu <>
Copy link

@rallytime rallytime commented Jun 8, 2018

@saltstack/team-suse Did any of you want to review this by chance?

isbm approved these changes Jun 9, 2018
Copy link

@isbm isbm left a comment

Sorry being late. Done!

@rallytime rallytime merged commit 6eee17d into saltstack:develop Jun 11, 2018
5 of 10 checks passed
5 of 10 checks passed
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23524 — ABORTED
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10565 — ABORTED
default Build finished.
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5594 — FAILURE
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19648 — FAILURE
WIP ready for review
codeclimate All good!
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25792 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17857 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22488 — SUCCESS
@10ne1 10ne1 deleted the dev/aratiu/upstream-nilrt-add-sysapi-reboot-support branch Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants