restartcheck/opkg: add NILRT "sysapi" reboot support #47722
Merged
+74
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
10ne1
force-pushed
the
dev/aratiu/upstream-nilrt-add-sysapi-reboot-support
branch
from
610de02 to
fb7bda0
Compare
The code was originally written with only kernel modules triggering system reboots, but it turns out other components within NILinuxRT need this functionality, so abstract out the reboot state logic so it's not kernel-module specific anymore. The abstracted logic basically functions the same as before: Packages modify a specific file on disk which gets its md5sum & timestamp stored under NILRT_RESTARTCHECK_STATE_PATH. The state files in turn are checked using restartcheck's new _file_changed_nilrt() function. Now we just call the generic _file_changed_nilrt() both for kernel modules and sysapi and anything else we might need in the future. Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Contributor
|
@saltstack/team-suse Did any of you want to review this by chance? |
rallytime
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds reboot detection to restartcheck when NILinuxRT "System API" plugins are installed by the package manager. More details in the commit message & function docstrings.
New Behavior
Restartcheck asks for reboots on NILinuxRT when a new type of packages gets installed.
Tests written?
No
Commits signed with GPG?
No