Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restartcheck/opkg: add NILRT "sysapi" reboot support #47722

Conversation

10ne1
Copy link
Contributor

@10ne1 10ne1 commented May 18, 2018

What does this PR do?

Adds reboot detection to restartcheck when NILinuxRT "System API" plugins are installed by the package manager. More details in the commit message & function docstrings.

New Behavior

Restartcheck asks for reboots on NILinuxRT when a new type of packages gets installed.

Tests written?

No

Commits signed with GPG?

No

@ghost ghost self-requested a review May 18, 2018 14:30
@10ne1 10ne1 force-pushed the dev/aratiu/upstream-nilrt-add-sysapi-reboot-support branch from 610de02 to fb7bda0 Compare May 23, 2018 14:53
Ioan-Adrian Ratiu and others added 2 commits May 23, 2018 17:54
The code was originally written with only kernel modules triggering
system reboots, but it turns out other components within NILinuxRT
need this functionality, so abstract out the reboot state logic so
it's not kernel-module specific anymore.

The abstracted logic basically functions the same as before: Packages
modify a specific file on disk which gets its md5sum & timestamp
stored under NILRT_RESTARTCHECK_STATE_PATH. The state files in turn
are checked using restartcheck's new  _file_changed_nilrt() function.

Now we just call the generic _file_changed_nilrt() both for kernel
modules and sysapi and anything else we might need in the future.

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
@rallytime
Copy link
Contributor

@saltstack/team-suse Did any of you want to review this by chance?

Copy link
Contributor

@isbm isbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry being late. Done!

@rallytime rallytime merged commit 6eee17d into saltstack:develop Jun 11, 2018
@10ne1 10ne1 deleted the dev/aratiu/upstream-nilrt-add-sysapi-reboot-support branch June 11, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants