New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename boto to botomod #47726

Merged
merged 3 commits into from May 25, 2018

Conversation

Projects
None yet
4 participants
@gtmanfred
Contributor

gtmanfred commented May 18, 2018

What issues does this PR fix or reference?

Fixes #47694

Tests written?

Yes

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-boto May 18, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 18, 2018

I will fix the rest of these imports on monday.

@terminalmage

@gtmanfred now that #47710 is merged, you may need to rebase and either modify the whitelist or add a __utils__ to the setup_loader_modules, if you start seeing some KeyError failures in the __utils__ dunder in the unit tests.

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 21, 2018

Sounds good, I am just working through the errors as they come back from the test suite 👍

gtmanfred added some commits May 18, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2018.3 branch from 8695276 to 43997a4 May 22, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 23, 2018

re-run py

@rallytime rallytime merged commit b860d95 into saltstack:2018.3 May 25, 2018

4 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5194 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23127 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10164 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19250 — ABORTED
Details
default Build finished.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25384 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17427 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22057 — SUCCESS
Details
@jbq

This comment has been minimized.

Contributor

jbq commented Sep 29, 2018

Could you please do a 2018.3.3 release for this? The boto warnings are sooooo boring, annoying and get in the way! Thanks a lot!

@rallytime

This comment has been minimized.

Contributor

rallytime commented Sep 30, 2018

@jbq This fix will be available in the upcming 2018.3.3 release. We're testing the release presently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment