New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stderr launchctl helper class and fix service mac tests #47753

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented May 21, 2018

What does this PR do?

Improve the error reporting for when the service is disabled message shows up in the launchctl stderr. Currently launchctl does not return a bad exit code so catching this error to report to the user they cannot start a service since its disabled. Also fixing the mac service tests. Currently this test is failing: integration.states.test_service.ServiceTest.test_service_running because i believe a test in modules.test_mac_service is disabling the service, so I improved the tearDown there as well to ensure we are setting the disable/enabled status back to what it was initially.

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 22, 2018

@Ch3LL Looks like this change caused a related failure:

  • integration.states.test_service.ServiceTest.test_service_running

https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/23036/

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 25, 2018

@Ch3LL This will need a rebase as well.

Ch3LL added some commits May 21, 2018

@Ch3LL Ch3LL force-pushed the Ch3LL:service_mac branch from 2f77f11 to 185c9e9 May 30, 2018

@rallytime rallytime merged commit 8f78e3a into saltstack:2018.3 May 31, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5374 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19430 — ABORTED
Details
default Build finished.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25570 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17643 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23308 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10345 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22273 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment