New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_pkg integration state tests to windows #47778

Merged
merged 3 commits into from May 25, 2018

Conversation

Projects
None yet
4 participants
@Ch3LL
Contributor

Ch3LL commented May 22, 2018

What does this PR do?

Allow the state test_pkg integration tests to run on windows.

What issues does this PR fix or reference?

#45016

Ch3LL added some commits May 22, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows May 22, 2018

@Ch3LL Ch3LL changed the title from Win state pkg to Add test_pkg integration state tests to windows May 22, 2018

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented May 23, 2018

Instead of hard coding a package sls file I suggest you pull them down individually or clone
https://github.com/saltstack/salt-winrepo
Given your fetching the software from the internet.

@@ -0,0 +1,24 @@
{% set versions = {'18':['05', '03', '01'], '16':['04', '03', '02', '00'], '9':['20']} %}

This comment has been minimized.

@damon-atkins

damon-atkins May 23, 2018

Member

See comments

This comment has been minimized.

@Ch3LL

Ch3LL May 23, 2018

Contributor

I think this is fine as this test isn't testing the salt-winrepo repo but only the functionality of pkg.install just as we are also doing for putty in the test repo. I believe it would be more useful to add tests specifically for win-repo if we want to test the repo files themselves. Hopefully we can move towards using our own build packages as well in the future. But would like to get @twangboy and @dwoz input here as well.

This comment has been minimized.

@dwoz

dwoz May 24, 2018

Contributor

@Ch3LL If the intent is to test pkg.install I am fine with this. I agree adding tests specifically for the win-repo functionality is a good future step.

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented May 23, 2018

testing the salt-winrepo repo

One item which most likely is not being tested is the settings in this section https://docs.saltstack.com/en/latest/ref/configuration/master.html#windows-software-repo-settings

If you were to pull down the salt-repo-ng you could use the above settings, which would increase the test coverage

@rallytime rallytime requested a review from dwoz May 23, 2018

@dwoz

dwoz approved these changes May 24, 2018

@rallytime rallytime merged commit 96b7c0c into saltstack:2017.7 May 25, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5250 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23184 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19306 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25440 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17528 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10221 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22158 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment