Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use pytz to calculate timezones #47788
What does this PR do?
Fixes issue where erroneous Timezones were being returned. Uses pytz module to get timzone information. Fixes
What issues does this PR fix or reference?
Everything was in a giant dictionary so the
The dictionary only has one possible option for the timezone it finds, so
Commits signed with GPG?
A couple changes need to be made to the release notes you added.
@twangboy To respond to this comment, if you read the gist closely it talks about having gotten the CLDR time zone information (that's the format with the offsets) from tzutil on Windows. This can apparently be done with the
/l flag. Did you try that?
Having said all this though, pytz is better suited to this sort of thing, and as long as it is A) only used on Windows, and B) already included in the embedded Python we distribute with Windows, then we should use pytz instead of trying to parse tzutil.
@terminalmage I did look at the gist. The