New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows to service disable ERROR check in tests #47816

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
4 participants
@Ch3LL
Contributor

Ch3LL commented May 24, 2018

What does this PR do?

Currently this test integration.modules.test_service.ServiceModuleTest.test_service_disable_doesnot_exist is failing on windows with the error:

Traceback (most recent call last):
  File "c:\users\admini~1\appdata\local\temp\kitchen\testing\tests\integration\modules\test_service.py", line 124, in test_service_disable_doesnot_exist
    self.assertFalse(enable)
AssertionError: 'ERROR: Failed To Open doesnotexist: The specified service does not exist as an installed service.' is not false

This is because the test was expecting False but sometimes the service disable check returns ERROR if the service does not exist, so updating the test to ensure windows changes the check for ERROR.

@gtmanfred gtmanfred merged commit c9cccf5 into saltstack:2017.7 May 24, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5234 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19290 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25424 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17512 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23168 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10204 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22142 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment