New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] orchestration results False when function is False #47843

Merged
merged 4 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@garethgreenaway
Member

garethgreenaway commented May 25, 2018

What does this PR do?

Updating function in saltmod to ensure that the result is a failure if the function being run returns as False.

What issues does this PR fix or reference?

#30367

Previous Behavior

Previously functions that returned False would still return in a True result in the orchestration results.

New Behavior

If the function being run in orchestration returns as False then the orchestration result is False.

Tests written?

Yes

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:30367_orch_return_false_when_function_fails branch from a3fdd53 to 80c6aeb May 25, 2018

garethgreenaway added some commits May 25, 2018

Updating function in saltmod to ensure that the result is a failure i…
…f the function being run returns as False.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:30367_orch_return_false_when_function_fails branch from 80c6aeb to 3e074be May 28, 2018

@rallytime rallytime requested a review from gtmanfred May 29, 2018

@cachedout

This comment has been minimized.

Contributor

cachedout commented May 29, 2018

LGTM but I would like to see some independent confirmation on this fix from the people in the OP issue.

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 30, 2018

This was confirmed to be working in #30367 (comment)

👍

@rallytime rallytime merged commit a0bf565 into saltstack:2018.3 May 30, 2018

5 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5359 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19415 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10330 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25555 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17630 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23293 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22260 — SUCCESS
Details

garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Jun 5, 2018

garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Jun 5, 2018

garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Jun 6, 2018

rallytime added a commit that referenced this pull request Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment